Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(map_based_prediction): prediction update #998

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Oct 31, 2023

Description

10月にAWFに入ったPredictionの修正を取り込みます。

Related links

パラメタファイルの追加が必要になるのでautoware_launchの方を先に更新したほうが良さそうです。
https://github.com/tier4/autoware_launch.xx1/pull/689

Tests performed

Psimで動作を確認

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

YoshiRi and others added 2 commits October 31, 2023 23:59
…e speed by setting control time horizon (autowarefoundation#5285)

* enable to control lateral path convergence speed by setting control time horizon

Signed-off-by: yoshiri <[email protected]>

* update readme

Signed-off-by: yoshiri <[email protected]>

* add comment  in generate path function

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
…autowarefoundation#5435)

* replace object yaw with lanelets yaw when object orientation is unavailable

Signed-off-by: yoshiri <[email protected]>

* fix unintended behavior: add escape and move replace state before path generation

Signed-off-by: yoshiri <[email protected]>

* Update perception/map_based_prediction/src/map_based_prediction_node.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Signed-off-by: yoshiri <[email protected]>
@shmpwk
Copy link
Collaborator

shmpwk commented Oct 31, 2023

pre-comit.ciが動かないので一旦closeしてopenすることで、triggerしてみます。

@shmpwk shmpwk closed this Oct 31, 2023
@shmpwk shmpwk reopened this Oct 31, 2023
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit d06733f into tier4:beta/v0.10.4 Oct 31, 2023
15 of 16 checks passed
@shmpwk
Copy link
Collaborator

shmpwk commented Oct 31, 2023

pre-commit.ci動かなかったですが、強制マージしました。

@YoshiRi YoshiRi deleted the chore/prediction_update branch November 4, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation perception
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants